feat: only install corresponding abi package when possible#5635
Open
farfromrefug wants to merge 9 commits intoNativeScript:mainfrom
Open
feat: only install corresponding abi package when possible#5635farfromrefug wants to merge 9 commits intoNativeScript:mainfrom
farfromrefug wants to merge 9 commits intoNativeScript:mainfrom
Conversation
…o install_abi_package
…d to rebuild for devices we are building for
…kage # Conflicts: # lib/controllers/build-controller.ts # lib/services/device/device-install-app-service.ts
…es for `run|debug` this passes a gradle `abiFilters` arg to the build process which could allow the gradle config to only build abis of connected devices. * build faster * could be used with split to only deploy a smaller apk to each device depending on its abi Default to false for now. Could become the default later It requires an update to the gradle file in the android runtime
# Conflicts: # lib/definitions/android-plugin-migrator.d.ts
Contributor
Author
|
@rigor789 i updated that PR with my latest changes. I now check for changes on next builds to see if the arch of the device is different from the arch of what we built previously. It now works in all cases |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the way the
installOnDeviceworks.The idea is to be compatible with apk split on android.
The reason for this is multiple:
The way it works is this:
.apkfiles were built:- 1: always install this one
- more than 1: if 64bit abi or 32bit abi package found use this one
- more than 1: if not look for universal one found use this one
- otherwise => error
I also applied the same rule for
copy copyLatestAppPackage To(thus renamed tocopyAppPackages)copyTois an existing directory or a path which does not end withaab|ipa|apkcopy all packages tocopyToas a directorycopyTois a file nameuniversalpackage if existingThere is one thing bugging be for which i have not found a solution. Because of this line if there are multiple packages there will be warning about it which is wrong in its meaning when using
run. Might also be wrong in other cases and we can simply remove the warning ...